compiletest: Don't modify testpaths when creating aux contexts#148199
Merged
bors merged 4 commits intorust-lang:masterfrom Nov 2, 2025
Merged
compiletest: Don't modify testpaths when creating aux contexts#148199bors merged 4 commits intorust-lang:masterfrom
testpaths when creating aux contexts#148199bors merged 4 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying
TestCx::testpathsmakes it vastly harder to reason about how compiletest is using test paths, and can be avoided without much trouble by simply passing explicit source-file paths into a small number of auxiliary-aware methods.This PR was originally based on a much larger change that split
TestPathsinto multiple structs and multipleTestCxfields (as seen in early revisions of #148160), but after further cleanups it turned out that very few tweaks were actually needed to avoid changes totestpaths.r? jieyouxu